New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove tag_cloud from core #1703

Merged
merged 2 commits into from May 13, 2015

Conversation

Projects
None yet
2 participants
@ingwinlu
Contributor

ingwinlu commented Apr 20, 2015

As discussed in #1598 and #1566 this breaks out tag cloud creation into a plugin, for which there is a PR in the pelican-plugins repo.

  • remove tag_cloud from core
  • add tag_cloud to pelican-plugins
  • add deprecation warnings that tag clouds are not available without plugin
@ingwinlu

This comment has been minimized.

Contributor

ingwinlu commented Apr 20, 2015

options for deprecation:

  • hack something together that checks if there are tag_cloud settings present but no tag_cloud plugin loaded later, will be hacky and does not integrate with how we do deprecation right now, will also not catch cases where a tag_cloud was in use without additional configuration
  • add a f.a.q. entry ala 'since i upgraded pelican my tag cloud does not show up anymore'
  • don't do anything

@justinmayer justinmayer added this to the 3.6 milestone May 13, 2015

@justinmayer

This comment has been minimized.

Member

justinmayer commented May 13, 2015

Thanks for taking care of this, Winlu. Much appreciated!

justinmayer added a commit that referenced this pull request May 13, 2015

Merge pull request #1703 from ingwinlu/remove_tag_cloud
Remove tag_cloud from Pelican core

@justinmayer justinmayer merged commit 8786732 into getpelican:master May 13, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ingwinlu ingwinlu deleted the ingwinlu:remove_tag_cloud branch Sep 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment