Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore None return value from get_generators signal #2850

merged 1 commit into from
Feb 18, 2021


Copy link

@avaris avaris commented Feb 12, 2021

Resolves: #2834

Ignores if nothing was returned from get_generators signal. Some plugins were using this signal primarily because it provided a convenient place in the run timeline and did not return any generator to register. They were cluttering log with error messages even though everything was working as expected.

  • [+] Ensured tests pass and (if applicable) updated functional test output
  • [+] Conformed to code style guidelines by running appropriate linting tools

Copy link

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Many thanks for fixing this.

Once this and the Pygments 2.8-related PR are merged, we can issue a new release containing both changes (and any other minor commits since the release last month).

@justinmayer justinmayer merged commit eaa801f into getpelican:master Feb 18, 2021
@avaris avaris deleted the less_noisy_logging branch October 25, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Version 4.5.2+ error
2 participants