ignore None return value from get_generators signal#2850
Merged
Conversation
justinmayer
approved these changes
Feb 18, 2021
Member
justinmayer
left a comment
justinmayer
left a comment
There was a problem hiding this comment.
Looks good to me. Many thanks for fixing this.
Once this and the Pygments 2.8-related PR are merged, we can issue a new release containing both changes (and any other minor commits since the release last month).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #2834
Ignores if nothing was returned from
get_generatorssignal. Some plugins were using this signal primarily because it provided a convenient place in the run timeline and did not return any generator to register. They were cluttering log with error messages even though everything was working as expected.