Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MIME types for web fonts #2929

Merged
merged 2 commits into from
Oct 8, 2021

Conversation

MinchinWeb
Copy link
Contributor

@MinchinWeb MinchinWeb commented Oct 2, 2021

Building on #2928, it seems Python doesn't recognize/return the proper MIME-type for webfonts. Firefox does seems to work fine either way (as opposed to CSS...), but this seemed simple and proper to fix.

Before:

After:

image

Pull Request Checklist

  • Ensured tests pass and (if applicable) updated functional test output
  • Conformed to code style guidelines by running appropriate linting tools
  • Added tests for changed code
  • [ n/a ] Updated documentation for changed code

P.S. If this could be marked "hacktoberfest-accepted" (so it counts towards my Hacktoberfest Pull Requests), that would be appreciated!

@MinchinWeb
Copy link
Contributor Author

This would resolved by python/cpython#20199, when it is merged into the Python core.

@avaris
Copy link
Member

avaris commented Oct 3, 2021

Well, either commits from another PR should not be here or these commit should go on to that PR instead. Now you're guaranteed to cause merge conflicts.

@MinchinWeb
Copy link
Contributor Author

@avaris I've fixed the extra commits issue; sorry about that. Should be good now.

pelican/server.py Outdated Show resolved Hide resolved
@justinmayer justinmayer changed the title Mimetypes for webfonts Add MIME types for web fonts Oct 8, 2021
@justinmayer
Copy link
Member

Thanks to @MinchinWeb for the enhancement and to @avaris for reviewing.

@justinmayer justinmayer merged commit 33ef2c5 into getpelican:master Oct 8, 2021
@MinchinWeb MinchinWeb deleted the mimetypes-webfonts branch October 11, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants