Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribute sample data used to run tests #2935

Closed
wants to merge 3 commits into from
Closed

Distribute sample data used to run tests #2935

wants to merge 3 commits into from

Conversation

BenSturmfels
Copy link
Contributor

Pelican distributes the unit tests, but doesn't distribute the sample data such as samples/pelican.conf.py required to run them.

I noticed this when updating the OS package for Guix which is based on the PyPI distribution of pelican.

@BenSturmfels
Copy link
Contributor Author

Actually - hold off on merging this - the * pattern is too wide and will pull in samples/__pycache__ which shouldn't be distributed. I'll test this further.

@justinmayer
Copy link
Member

As a tangential aside, I am fairly confident we will soon switch from building Pelican via Setuptools to instead building via Poetry. The only reason we haven't done that already is because Pip does not yet support editable installs of non-Setuptools builds. Now that support for PEP 660 has been merged into Pip, I imagine we will make that switch as soon as Pip 21.3 is released.

In short, once we make that switch, MANIFEST.in will be going away, and this type of configuration will need to be performed in the pyproject.toml file.

@justinmayer justinmayer changed the title Distribute sample data used to run tests. Distribute sample data used to run tests Oct 8, 2021
@BenSturmfels
Copy link
Contributor Author

Great, thanks for the context on Poetry/MANIFEST.in.

I've just updated MANIFEST.in again to explicitly exclude samples/__pycache__.

MANIFEST.in Outdated Show resolved Hide resolved
Copy link
Member

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the enhancement, Ben! ✨

@justinmayer
Copy link
Member

Merged manually via aeec09b and 99c935d.

@BenSturmfels BenSturmfels deleted the include-samples branch October 29, 2021 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants