Skip to content

Remove unreliable WRITE_SELECTED feature - #3243

Merged
justinmayer merged 1 commit into
getpelican:masterfrom
avaris:remove-write-selected
Nov 12, 2023
Merged

Remove unreliable WRITE_SELECTED feature#3243
justinmayer merged 1 commit into
getpelican:masterfrom
avaris:remove-write-selected

Conversation

@avaris

@avaris avaris commented Nov 12, 2023

Copy link
Copy Markdown
Member

Implementation is buggy and unreliable. Therefore, it is better to remove the functionality until a robust implementation is added.

Pull Request Checklist

Resolves: #2678

  • Ensured tests pass and (if applicable) updated functional test output
  • Conformed to code style guidelines by running appropriate linting tools
  • Added tests for changed code
  • Updated documentation for changed code

Implementation is buggy and unreliable. Therefore, it is better to
remove the functionality until a robust implementation is added.
@avaris
avaris requested a review from justinmayer November 12, 2023 16:48
@avaris avaris changed the title remove WRITE_SELECTED Eemove WRITE_SELECTED Nov 12, 2023
@avaris avaris changed the title Eemove WRITE_SELECTED Remove WRITE_SELECTED Nov 12, 2023
@justinmayer justinmayer changed the title Remove WRITE_SELECTED Remove unreliable WRITE_SELECTED feature Nov 12, 2023

@justinmayer justinmayer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this, @avaris! 👏

@justinmayer
justinmayer merged commit 9525583 into getpelican:master Nov 12, 2023
@avaris
avaris deleted the remove-write-selected branch November 12, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is it possible write-selected just doesn't work?

2 participants