Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
add disqus_url to comment js block #669
By default, the
Once set, the thread will use that
So, I change the
Hi Leroy. Thanks for your contribution, which seems like a good practice. A few comments...
I'm not sure that
In summary, could we not simply do the following to include the
And actually, this brings up a topic that I've brought up on IRC before... Should we not simply disable the entire Disqus comment
Instead of the following in
... why not something like this?
If that were the default, the scope of this pull request could be changed to adding a single line:
What do you think?
Thanks for your reply.
I agree with you that
Other than that, I think the way you suggested are much more clean and should work the same.
Actually, you're quite right... Since I don't use the
I'll bring this up with some other folks and solicit some ideas.
After a brief discussion in IRC, I suspect we'll resolve this (for now) by changing the default value for
Hey @ametaireau is it enough to use SITEURL ? I have just tried to use this solution in my template while using:
It seems that SITEURL will end up as "../../../" instead of an empty string "", therefore I have used the following solution:
Which seems to work, what do you think?