New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown summary should not include content footnote #885

Merged
merged 1 commit into from May 13, 2013

Conversation

Projects
None yet
5 participants
@avaris
Member

avaris commented May 10, 2013

Markdown instance carries state for subsequent uses. Content
and summary parsing is done with the same instance. Since
footnotes are processed with an extension and stored as state,
content footnote is duplicated for summary.

This PR adds a .reset() call before summary parsing to clear
the state. It also adds a test case with footnotes.

Markdown summary should not include content footnote
Markdown instance carries state for subsequent uses. Content
and summary parsing is done with the same instance. Since
footnotes are processed with an extension and stored as state,
content footnote is duplicated for summary.

This PR adds a ``.reset()`` call before summary parsing to clear
the state. It also adds a test case with footnotes.
@justinmayer

This comment has been minimized.

Member

justinmayer commented May 13, 2013

Awesome. Thanks, Avaris!

justinmayer added a commit that referenced this pull request May 13, 2013

Merge pull request #885 from avaris/markdown-summary-footnote
Markdown summary should not include content footnote

@justinmayer justinmayer merged commit 7115043 into getpelican:master May 13, 2013

1 check passed

default The Travis CI build passed
Details
@peterdesmet

This comment has been minimized.

Contributor

peterdesmet commented Aug 10, 2013

Not sure if this is related, but on my Pelican installation, footnotes are (still) included in {{ article.summary }}, even though my settings indicate not to have any default summary at all: SUMMARY_MAX_LENGTH = 0

For an html example, see this issue.

@vmalloc

This comment has been minimized.

vmalloc commented Aug 28, 2013

+1, for me footnotes still appear when using {{article.summary}}.

@Gastove

This comment has been minimized.

Gastove commented Sep 16, 2013

Yep, same here, I'm afraid. Footnotes feature in both {{article.content}} and {{article.summary}}.

@justinmayer

This comment has been minimized.

Member

justinmayer commented Sep 16, 2013

None of the commenters here have specified which Pelican version is being used. As noted at the top of this issue, this fix is marked with the 3.3 milestone, so if you're using the current 3.2.x release, then of course you're going to see the previous (unfixed) behavior. If, on the other hand, the comments above are in reference to the current master, then please indicate that explicitly so we can determine if further action is warranted.

@Gastove

This comment has been minimized.

Gastove commented Sep 16, 2013

Ack! Apologies -- you're quite right, I a) missed the 3.3 milestone marker, b) forgot to specify my version, and c) am using 3.2.2. Sorry again, and thanks for the fix!

@peterdesmet

This comment has been minimized.

Contributor

peterdesmet commented Sep 16, 2013

Thanks for the update! I am also using 3.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment