Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish canary builds #3084

Merged
merged 3 commits into from
Apr 27, 2024
Merged

Publish canary builds #3084

merged 3 commits into from
Apr 27, 2024

Conversation

kichristensen
Copy link
Contributor

What does this change

Fixes the porter-canary action so it can run when changes are pushed to main or release/* branches.
Also removes the workflow_dispatch trigger, but that is up for discussion as it also removes the functionality to manually trigger the action if needed.
And for readability names is added to the integration test steps.

What issue does it fix

Closes #3073

Notes for the reviewer

It is hard to test if it works a 100% as I cannot run or trigger the action in the porter repository to see the full flow, and check if everything is pushed as it should be.

As mentioned the removal of the workflow_dispatch trigger is up for discussion, as it removes the ability to manually run the action if needed. But if we want it to stay, then conditions on the jobs on job needs to be introduced, as inputs can only be passed on when through workflow_dispatch, which is not pretty in YAML or in the action view. So it would look something like this:

  build_pipelinesrelease_template_workflow_dispatch:
    if: ${{ github.event_name == 'workflow_dispatch' }}
    name: build_pipelinesrelease_template_workflow_dispatch
    uses: ./.github/workflows/build_pipelinesrelease_template.yml
    with:
      registry: ghcr.io/getporter
      shouldPublish: "${{inputs.shouldPublish}}"
      skipTests: "${{inputs.skipTests}}"
  build_pipelinesrelease_template_push:
    if: ${{ github.event_name == 'push' }}
    name: build_pipelinesrelease_template_push
    uses: ./.github/workflows/build_pipelinesrelease_template.yml

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Signed-off-by: Kim Christensen <kimworking@gmail.com>
Signed-off-by: Kim Christensen <kimworking@gmail.com>
Signed-off-by: Kim Christensen <kimworking@gmail.com>
@schristoff schristoff merged commit 57b80e2 into getporter:main Apr 27, 2024
15 checks passed
@kichristensen kichristensen deleted the canaryBuild branch June 10, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Canary builds are not published
2 participants