Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update returning #1720

Merged
merged 4 commits into from Dec 17, 2019
Merged

Update returning #1720

merged 4 commits into from Dec 17, 2019

Conversation

@juliano
Copy link
Collaborator

juliano commented Nov 29, 2019

Fixes #572

Problem

We don't have support to UPDATE ... RETURNING

Solution

Implemented update.returning for Postgres, Sql Server and Oracle

Notes

Additional notes.

Checklist

  • Unit test all changes
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes
  • Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

@juliano juliano requested a review from deusaquilus Dec 1, 2019
@juliano juliano changed the title [WIP] Update returning Update returning Dec 1, 2019
Copy link
Collaborator

mdedetrich left a comment

Looks good to me

@mdedetrich mdedetrich merged commit 5bda62a into getquill:master Dec 17, 2019
1 of 3 checks passed
1 of 3 checks passed
codecov/patch 66.66% of diff hit (target 92.78%)
Details
codecov/project 92% (-0.78%) compared to 5a18c5b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@juliano juliano deleted the juliano:update-returning branch Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.