New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBoss JIRA] (RAILO-112​0) IE 8 Security / Access page blank #31

Merged
merged 2 commits into from Dec 27, 2011

Conversation

Projects
None yet
2 participants
@vkras

vkras commented Dec 5, 2011

.../browse/RAILO-1120

@vkras

This comment has been minimized.

vkras commented Dec 9, 2011

Fix for "RAILO-554 Multi-select of datasources in admin fails in IE8" in addition to JBoss JIRA IE 8 Security / Access page blank

micstriit pushed a commit that referenced this pull request Dec 27, 2011

Michael Offner
Merge pull request #31 from vkras/master
[JBoss JIRA] (RAILO-112​0) IE 8 Security / Access page blank

@micstriit micstriit merged commit 453cffc into getrailo:master Dec 27, 2011

@micstriit

This comment has been minimized.

Contributor

micstriit commented Dec 27, 2011

i have seen to late that the pull request was made again the master branch and should be again the "3.3" branch, we will add this changes to "3.3" branch as well.

@micstriit

This comment has been minimized.

Contributor

micstriit commented Dec 27, 2011

changes in branch "3.3"
44d6858

@vkras

This comment has been minimized.

vkras commented Jan 12, 2012

I just installed the latest 3.3.1.009.
RAILO-1120 IE 8 Security / Access page blank - can be set to Resolved, it works fine.

Something happened during merge for the RAILO-554 Multi-select of datasources in admin fails in IE8 (https://github.com/vkras/railo/commit/6adcc36dc3f1f9c31a9e169e74c5f346aab3efe2).
If my changes, fix looked like this:
if(form.elements[key] && (""+form.elements[key].name).indexOf("row_")==0){

The version I installed, looks like this (please note location of brackets):
if((form.elements[key] && ""+form.elements[key].name).indexOf("row_")==0){

It's wrong, it throws JS error in IE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment