Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade frontend stack #1125

Closed
arikfr opened this issue Jun 14, 2016 · 7 comments

Comments

@arikfr
Copy link
Member

commented Jun 14, 2016

Our frontend stack is becoming more and more outdated which makes keeping up with best practices harder. Once we start actually working on this, we should probably split this into multiple steps.

  1. Upgrade to Angular 1.5 (we're on 1.2 at the moment...).
  2. Switch to using npm and Webpack instead of Bower & Gulp. We can consider using SystemJS, but looks like Webpack is industry standard, so probably better to stick to it.
  3. Implement latest style guide -- mainly rewrite all our directives as components, remove controllers, etc.
  4. Reduce dependency on Angular specific stuff (angular.module, service, etc) by using regular Javascript modules.
  5. ... significant time later ... Rewrite all components as React components 😝 .
@ninneko

This comment has been minimized.

Copy link
Contributor

commented Jun 23, 2016

I feel it hard to understand frontend codes, so I will be happy when refactor frontend codes.

@arikfr

This comment has been minimized.

Copy link
Member Author

commented Aug 18, 2016

@eiso

This comment has been minimized.

Copy link

commented Oct 27, 2016

@arikfr I saw you're about to work on this, out of curiosity are you switching to yarn instead of npm?

@arikfr

This comment has been minimized.

Copy link
Member Author

commented Oct 27, 2016

@eiso not sure. I might give it a try and if it just works will try to use it, but it's less of a priority right now.

@arikfr arikfr referenced this issue Nov 6, 2016
22 of 22 tasks complete

@arikfr arikfr closed this in #1376 Nov 28, 2016

@danlg

This comment has been minimized.

Copy link

commented May 19, 2017

@arikfr ... Rewrite all components as React components.. at least one so that people who want to contribute and add react component in a plugin manner like grafana in redash can do it. You should reopen this issue as this is not finished.

@oliviertassinari

This comment has been minimized.

Copy link

commented Nov 9, 2018

... significant time later ... Rewrite all components as React components stuck_out_tongue_closed_eyes .

It's never too late to use React 👌.

@kravets-levko

This comment has been minimized.

Copy link
Collaborator

commented Nov 9, 2018

It's never too late to use React

@oliviertassinari It's already in progress 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.