New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query description field location is less discoverable #2714

Open
emtwo opened this Issue Aug 1, 2018 · 7 comments

Comments

Projects
None yet
5 participants
@emtwo
Copy link
Contributor

emtwo commented Aug 1, 2018

I'm not sure if this was on purpose, but it seems that the field for adding a description for a query has moved to the bottom left corner of the query editor which is slightly less discoverable in my opinion than right next to the query title.
query_description

@arikfr

This comment has been minimized.

Copy link
Member

arikfr commented Aug 5, 2018

It moved to make room for the new tags feature while making sure we don't push down the main content (query/visualization) too much down.

We're open to suggestions though and even more so happy to learn how you use query descriptions.

cc: @kocsmy

@arikfr

This comment has been minimized.

Copy link
Member

arikfr commented Aug 27, 2018

@emtwo can you please share some examples of how you use this field at Mozilla? Thanks!

@emtwo

This comment has been minimized.

Copy link
Contributor Author

emtwo commented Aug 29, 2018

@arikfr Different people may be using that field differently at Mozilla. However, the most common use-case I've seen is simply to provide a description of a visualization to help a user understand it.

Here is one example:

screen shot 2018-08-29 at 11 16 35 am

@kocsmy

This comment has been minimized.

Copy link
Collaborator

kocsmy commented Aug 29, 2018

@arikfr where did we move this, in 5.0? I can't specifically remember and on 4.0 it's still next to the header (and it's not really pushing down the content if the query header isn't super long):
screenshot 2018-08-29 17 24 44

@sreynen

This comment has been minimized.

Copy link
Contributor

sreynen commented Jan 22, 2019

To add another use case: in addition to explaining the results of a query, we also use descriptions to explain parameters and sometimes even the query itself when multiple people are editing a query. So ideally the description would be placed before all of that.

@arikfr

This comment has been minimized.

Copy link
Member

arikfr commented Jan 23, 2019

@sreynen thank you for the additional use case! We tried to keep the top section minimal so it won't push down the query editor and results.

What if we kept the description where it is now or even behind some button in the edit mode of the query, but moved it up in the results mode? (see #3087 for new layout of results only view)

Calling @ranbena to join the discussion :)

@ranbena

This comment has been minimized.

Copy link
Member

ranbena commented Jan 26, 2019

Let's continue discussion in Discussion #3099

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment