New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event annotations (deploys, downtimes, etc) as horizontal bars on graphs #30

Open
arikfr opened this Issue Oct 28, 2013 · 10 comments

Comments

Projects
None yet
9 participants
@arikfr
Copy link
Member

arikfr commented Oct 28, 2013

No description provided.

@eshel

This comment has been minimized.

Copy link

eshel commented Apr 24, 2014

Event annotations can be generalized to "X Axis Annotations", for any X axis data type (dates, numbers, categories, whatever).
While we're at it, Y axis annotations can be useful as well. Would be useful to visualize "red lines" clearly (values too high or too low).

@dovahcrow

This comment has been minimized.

Copy link

dovahcrow commented Aug 3, 2016

+1

@davismtl

This comment has been minimized.

Copy link

davismtl commented Nov 21, 2016

+1
Google Analytics integrates this really well and might be worth using as inspiration.

When there is an anomaly on a chart, everyone on our team ends up having to look up the cause and then usually forget and have to look up a few more times in the future.

Stats are most useful when explanations are accompanied.

Implementation ideas:

  • Perhaps allow to add to 1 chart or to all.
  • Or allow to enable annotation on a per chart basis.
  • Allowing to group events into categories could be useful too (e.g. tags, categories or keywords). This could avoid having too many annotations if you are part of a big org (e.g. Mozilla).
@mohitrao

This comment has been minimized.

Copy link

mohitrao commented Dec 6, 2016

+1 be able to drop a pin on a point of a chart and add a note or a url for commentary

@JMbw

This comment has been minimized.

Copy link

JMbw commented Sep 19, 2017

+1

2 similar comments
@benmiroglio

This comment has been minimized.

Copy link

benmiroglio commented Feb 12, 2018

+1

@armandoFanbot

This comment has been minimized.

Copy link

armandoFanbot commented Aug 27, 2018

+1

@davismtl

This comment has been minimized.

Copy link

davismtl commented Sep 17, 2018

In terms of what this would look like, we have two good sources of inspiration. Mozilla uses Google Analytics and Amplitude which both have annotations.

Comparison

  • Google Analytics puts them under the chart as a list sorted by date in a collapsible menu
  • Amplitude puts vertical bars on the charts to show that there is an annotation for that date
@thoechsmann

This comment has been minimized.

Copy link

thoechsmann commented Sep 26, 2018

+1

@arikfr

This comment has been minimized.

Copy link
Member Author

arikfr commented Jan 28, 2019

Some notes from discussing this feature during a team call:

  • The idea is that annotation are a comment anchored to some point in the chart (at the call we discussed X axis anchoring, but reviewing comments from issue, I see that Y axis anchoring definitely makes sense too).
  • Annotation are a form of comment that is anchored to some point in the visualization. They will be persisted forever, and if not visible from the chart (because the point is no longer in view) then they can be seen from the "comments" section.
  • As a follow up feature, we can implement unanchored comments, but should start from annotations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment