New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving Data only view of query page #3087

Open
kocsmy opened this Issue Nov 16, 2018 · 9 comments

Comments

Projects
None yet
2 participants
@kocsmy
Copy link
Collaborator

kocsmy commented Nov 16, 2018

I've played a bit with the query data only view to further improve this view.

Just throwing in a couple of ideas, including iterative improvements and new concepts as well.

@kocsmy

This comment has been minimized.

Copy link
Collaborator Author

kocsmy commented Nov 16, 2018

Bringing meta data to the top more in place:

query view only
query view only 2

@kocsmy

This comment has been minimized.

Copy link
Collaborator Author

kocsmy commented Nov 16, 2018

Hide left sidebar entirely

query view only 3
query view only 3 fixed

@kocsmy

This comment has been minimized.

Copy link
Collaborator Author

kocsmy commented Nov 16, 2018

Card layout

This design approaches the data only query page as a mini dashboard where the data is presented in similar card like layouts we use on the dashboards.

query view only 4 card view

@arikfr

This comment has been minimized.

Copy link
Member

arikfr commented Nov 18, 2018

Screenshot 3 is the one that makes the most sense:

  • Get rid of the sidebar.
  • Give the data full width.

But I also like the look of the cards version. I don't think we should show all visualizations in a single view, but I do like the rest.

Maybe we can try merging screenshot 3 with the cards version:

  • Cards based sections.
  • The data section will retain tabs and be full width?
@kocsmy

This comment has been minimized.

Copy link
Collaborator Author

kocsmy commented Nov 20, 2018

Here's the merged version:
query view only 4 card view copy

I'm not 100% sure this is the right direction, the mixed fixed and fluid elements feels a bit strange to me. I'm also not 100% convinced that a so much different view/edit pages is the right direction.

@arikfr

This comment has been minimized.

Copy link
Member

arikfr commented Nov 20, 2018

How about all sections will be full width?

@kocsmy

This comment has been minimized.

Copy link
Collaborator Author

kocsmy commented Nov 21, 2018

Yes, full width works much better.

query view only 4 card view copy

@arikfr

This comment has been minimized.

Copy link
Member

arikfr commented Nov 25, 2018

Yes, I agree this is better. Some notes:

  1. The results & parameters sections should be similar to how they look like in query source view.
  2. Instead of the "Datasource" label we can use the database icon. Also why is it in a different row than the other metadata details?
  3. There is no Execute button...
@kocsmy

This comment has been minimized.

Copy link
Collaborator Author

kocsmy commented Dec 12, 2018

I've refined this as requested:

  • Results & Params are now in the same section.
  • For the datasource icon, I used the specific database icon which is a really nice addition.
  • Execute btn added.

query view only 4 card view copy

I explored how it would look like if we go with the sticky bottom section; I think this might even work better.

query view only 4 card view copy 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment