Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pie chart: sectors colors #2616

Merged
merged 1 commit into from Jul 31, 2018
Merged

Pie chart: sectors colors #2616

merged 1 commit into from Jul 31, 2018

Conversation

@kravets-levko
Copy link
Collaborator

kravets-levko commented Jun 21, 2018

Allow to choose colors for Pie chart sectors.

  1. Add new tab for color settings: for Pie charts it shows list of values, for other types - list of series:
    image

  2. Hide some options (left/right axis, series type) for Pie chart on Series tab as that options are not applicable to Pie charts:
    image
    image

@kocsmy

This comment has been minimized.

Copy link
Collaborator

kocsmy commented Jun 22, 2018

@kravets-levko maybe should we show something like "Not applicable for Pie Charts" text if they are not relevant?

@kravets-levko

This comment has been minimized.

Copy link
Collaborator Author

kravets-levko commented Jun 22, 2018

@kocsmy this text is too long to show it instead of hidden controls :-) but we can disable that inputs and add title="Not applicable for Pie Charts" so user will see it on mouseover

@arikfr arikfr merged commit 85230e3 into getredash:master Jul 31, 2018
2 of 3 checks passed
2 of 3 checks passed
codeclimate 1 issue to fix
Details
WIP ready for review
Details
ci/circleci Your tests passed on CircleCI!
Details
@arikfr

This comment has been minimized.

Copy link
Member

arikfr commented Jul 31, 2018

🍾

@jezdez jezdez mentioned this pull request Aug 15, 2018
@kravets-levko kravets-levko deleted the kravets-levko:feature/pie-colors branch Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.