New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build custom alert message #3137

Open
wants to merge 7 commits into
base: master
from

Conversation

Projects
4 participants
@k-tomoyasu
Copy link

k-tomoyasu commented Nov 28, 2018

Build custom alert messages with query results.

Alert feature is useful but we cannot see detail about query result.
This feature enable us write custom alert messages with query results (using template engine Jinja2).

WIP yet. I would appreciate if give me feedback.

alert destination

  • email
  • slack
  • webhook
  • hipchat
  • chatworks
  • pagerduty
  • mattermost

setting
2018-12-01 20 33 22

slack alert
2018-12-01 20 31 13

@kocsmy

This comment has been minimized.

Copy link
Collaborator

kocsmy commented Nov 28, 2018

Nice feature @k-tomoyasu — regarding the color of the preview button: we don't use that color so using btn-default would make sense. I'll think about having a better layout for this in the meantime.

@k-tomoyasu

This comment has been minimized.

Copy link

k-tomoyasu commented Dec 1, 2018

Nice feature @k-tomoyasu — regarding the color of the preview button: we don't use that color so using btn-default would make sense. I'll think about having a better layout for this in the meantime.

@kocsmy Thanks for your advice!
Firstly, I changed button color (and some fixes) and update screenshots.

@jupe

This comment has been minimized.

Copy link

jupe commented Jan 18, 2019

When we get this in ? Could rest of integrations be done in follow-up PR? I would like to get this first for emails and for slack..

@wafflebot wafflebot bot added the in progress label Jan 19, 2019

@k-tomoyasu k-tomoyasu changed the title WIP Build custom alert message Build custom alert message Jan 19, 2019

@k-tomoyasu

This comment has been minimized.

Copy link

k-tomoyasu commented Jan 19, 2019

@jupe Thanks for your comment!

Could rest of integrations be done in follow-up PR?

That's a big help if it is OK.
I was not good progress of integration because rest destinations are not easy to debug in my environment.

@jupe

This comment has been minimized.

Copy link

jupe commented Jan 19, 2019

For our case email&slack would be enough. Most probably we doesn’t need anything else, at least in near future. Currently slack alert is almost useless because it gives just title, not even link.. so this would be really welcome feature :)

@arikfr arikfr added this to Needs review in Pull Requests Jan 22, 2019

@arikfr arikfr added PR: unreviewed and removed in progress labels Jan 23, 2019

@arikfr arikfr self-assigned this Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment