Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawer menu with recreated close button #3889

Merged
merged 2 commits into from Jun 9, 2019

Conversation

Projects
None yet
2 participants
@ranbena
Copy link
Member

commented Jun 7, 2019

  • Refactor
  • Feature

Description

UX discussion here https://discuss.redash.io/t/should-the-help-drawer-retain-state/3832/8.

This is the first PR to make the drawer menu. The next would introduce the "Open in new window" button alongside the close button.

This discussion lead me to implement this and close #3880.

Mobile & Desktop Screenshots

No regression, looks identical to prev

Screen Shot 2019-06-08 at 0 42 46

New features - background, tooltip
Screen Shot 2019-06-08 at 0 42 41

@ranbena ranbena force-pushed the drawer-menu branch from 6dd9568 to e39c932 Jun 7, 2019

@@ -47,12 +47,6 @@
@zindex-picker: 2050;
@zindex-tooltip: 2060;

.@{drawer-prefix-cls} {
&.help-drawer {
z-index: 3000; // help drawer should be topmost

This comment has been minimized.

Copy link
@ranbena

ranbena Jun 7, 2019

Author Member

This didn't allow a tooltip to appear for drawer elements.
I tested and found no regression.

This comment has been minimized.

Copy link
@ranbena

ranbena Jun 8, 2019

Author Member

Proof:

Screen Shot 2019-06-08 at 12 46 11

@ranbena ranbena requested review from kravets-levko and gabrieldutra Jun 7, 2019

@ranbena ranbena self-assigned this Jun 7, 2019

@ranbena ranbena referenced this pull request Jun 7, 2019

Closed

Reduce help drawer close button click area #3880

1 of 1 task complete

@ranbena ranbena force-pushed the drawer-menu branch from e39c932 to 24363b1 Jun 8, 2019

@ranbena ranbena force-pushed the drawer-menu branch from 24363b1 to 1f1f908 Jun 8, 2019

@ranbena ranbena referenced this pull request Jun 8, 2019

Merged

Added “Open in new window” drawer menu button #3890

1 of 1 task complete

@ranbena ranbena merged commit dda75cc into master Jun 9, 2019

18 of 20 checks passed

Header rules No header rules processed
Details
Pages changed 11 new files uploaded
Details
Cypress All tests passed.
Details
Datree Smart Policy Best Practices Verification
Details
Datree insights datreeio insights events
Details
Mixed content No mixed content detected
Details
Redirect rules 7 redirect rules processed
Details
WIP Ready for review
Details
build Workflow: build
Details
ci/circleci: backend-unit-tests Your tests passed on CircleCI!
Details
ci/circleci: frontend-e2e-tests Your tests passed on CircleCI!
Details
ci/circleci: frontend-lint Your tests passed on CircleCI!
Details
ci/circleci: frontend-unit-tests Your tests passed on CircleCI!
Details
ci/circleci: legacy-python-flake8-tests Your tests passed on CircleCI!
Details
ci/circleci: python-flake8-tests Your tests passed on CircleCI!
Details
codeclimate All good!
Details
deploy/netlify Deploy preview ready!
Details
percy/redash Visual review automatically approved, no visual changes found.
Details
security/snyk - package.json (arikfr) No manifest changes detected
security/snyk - requirements.txt (arikfr) No manifest changes detected

@ranbena ranbena deleted the drawer-menu branch Jun 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.