Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork keep visualizations order #4067

Merged
merged 4 commits into from Aug 14, 2019

Conversation

@Jakdaw
Copy link
Contributor

commented Aug 13, 2019

What type of PR is this? (check all applicable)

  • Bug Fix

Description

At present when a query is forked the new query might not have the visualisations in the same order as in the original query. There's no way to reorder them in the UI, so let's make sure we maintain the same order.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Jakdaw added some commits Mar 27, 2019

Merge pull request #2 from getredash/master
Update from getredash/redash

@kravets-levko kravets-levko requested review from arikfr and rauchy Aug 13, 2019

@rauchy

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

LGTM. Wondering in what scenarios are forked visualizations ordered differently though?

@kravets-levko

This comment has been minimized.

Copy link
Collaborator

commented Aug 13, 2019

Wondering in what scenarios are forked visualizations ordered differently though?

Generally, if you omit ORDER BY clause from SQL query, order of records is undefined (DB engine can return records in any order). Usually (but not a must) DB will return records ordered by primary key or any other key used to process the query.

@arikfr arikfr merged commit d49514a into getredash:master Aug 14, 2019

15 of 18 checks passed

Datree Smart Policy Best Practices Verification
Details
Header rules No header rules processed
Details
Pages changed All files already uploaded
Details
Datree insights datreeio insights events
Details
Mixed content No mixed content detected
Details
Redirect rules 7 redirect rules processed
Details
WIP Ready for review
Details
build Workflow: build
Details
ci/circleci: backend-unit-tests Your tests passed on CircleCI!
Details
ci/circleci: frontend-e2e-tests Your tests passed on CircleCI!
Details
ci/circleci: frontend-lint Your tests passed on CircleCI!
Details
ci/circleci: frontend-unit-tests Your tests passed on CircleCI!
Details
ci/circleci: legacy-python-flake8-tests Your tests passed on CircleCI!
Details
ci/circleci: python-flake8-tests Your tests passed on CircleCI!
Details
codeclimate All good!
Details
cypress: default-group 95 tests passed in 09:44
Details
deploy/netlify Deploy preview ready!
Details
percy/redash Visual review automatically approved, no visual changes found.
Details
@arikfr

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

Thanks!

You might want to associate the email address in your Git commit with your GitHub account so this is probably represented in the contributors tab here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.