Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix netlify preview redirect loop in Safari #4083

Closed
wants to merge 1 commit into from
Closed

Conversation

ranbena
Copy link
Contributor

@ranbena ranbena commented Aug 19, 2019

  • Bug Fix

Description

In Safari, accessing Netlify Preview logged-out results in redirect loop.

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@@ -10,7 +10,7 @@

[[redirects]]
from = "/login"
to = "http://preview-login.redashapp.com/login"
to = "https://preview-login.redashapp.com/login"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember exactly why (was it necessary or just convenient), but preview-login doesn't support https.

But why do you think it's causing the issue you see? It redirects to a different page. Also, as @susodapop mentioned, calling /login directly works for him.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why do you think it's causing the issue you see? It redirects to a different page.

I think it might be a browser security restriction that Safari carries out.

Also, as @susodapop mentioned, calling /login directly works for him.

Calling directly is ok, but redirecting from https to http might be disallowed.

I dunno. I'll look into it a bit but I don't really care 😬

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arikfr maybe the api/session retries simply don't let the redirect happen. Are the retries and redirect coded explicitly or are they abstracted in some login mechanism?

@ranbena
Copy link
Contributor Author

ranbena commented Aug 19, 2019

lol this won't work cause these urls aren't actually accessible with https.
@arikfr can you do sth about it?

@ranbena
Copy link
Contributor Author

ranbena commented Oct 5, 2019

Dunno how to fix. Abandoning.

@ranbena ranbena closed this Oct 5, 2019
@guidopetri guidopetri deleted the netlify-loop branch July 22, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants