Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oracle: update DSN construction to support special characters in user/password. #4659

Merged
merged 3 commits into from Feb 27, 2020

Conversation

@juanvasquezreyes
Copy link
Contributor

juanvasquezreyes commented Feb 18, 2020

The reason I propose this change is to fix an issue when oracle password has an @
example of connection string: user/p@ssword@host

What type of PR is this? (check all applicable)

  • Bug Fix

Description

Currently oracle.py is building a query string, but if the DB password has an @ it doesn't work cause it build a connection string like: user/p@ssword@host

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

The reason I propose this change is to fix an issue when oracle password has an @
example of connection string: user/p@ssword@host
Copy link
Member

arikfr left a comment

Thanks! Please see comment.

self.configuration["host"],
self.configuration["port"],
service_name=self.configuration["servicename"])
connection = cx_Oracle.connect(user=self.configuration["user"],password=self.configuration["password"], dsn=dsn_t)

This comment has been minimized.

Copy link
@arikfr

arikfr Feb 24, 2020

Member

Thanks, but this is make the creation of connection_string in the constructor redundant. Let's remove the dead code there as well.

This comment has been minimized.

Copy link
@juanvasquezreyes

juanvasquezreyes Feb 24, 2020

Author Contributor

Just updated it, thanks

juanvasquezreyes and others added 2 commits Feb 24, 2020
Fixing init after comments
@arikfr
arikfr approved these changes Feb 27, 2020
Copy link
Member

arikfr left a comment

Thanks 👍

@arikfr arikfr changed the title Update oracle.py Oracle: update DSN construction to support special characters in user/password. Feb 27, 2020
@arikfr arikfr merged commit 5d533a3 into getredash:master Feb 27, 2020
16 of 17 checks passed
16 of 17 checks passed
percy/redash 31 visual changes need review
Details
Header rules No header rules processed
Details
Pages changed All files already uploaded
Details
Datree Smart Policy Best Practices Verification
Details
Datree insights datreeio insights events
Details
Mixed content No mixed content detected
Details
Redirect rules 7 redirect rules processed
Details
WIP Ready for review
Details
build Workflow: build
Details
ci/circleci: backend-lint Your tests passed on CircleCI!
Details
ci/circleci: backend-unit-tests Your tests passed on CircleCI!
Details
ci/circleci: frontend-e2e-tests Your tests passed on CircleCI!
Details
ci/circleci: frontend-lint Your tests passed on CircleCI!
Details
ci/circleci: frontend-unit-tests Your tests passed on CircleCI!
Details
cypress: default-group 129 tests passed in 15:30
Details
deploy/netlify Deploy preview ready!
Details
restyled No differences
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.