Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: replace HighCharts with Plotly #687

Merged
merged 4 commits into from Dec 9, 2015
Merged

Conversation

@alonho
Copy link
Contributor

alonho commented Dec 5, 2015

Solves #273

@alonho
Copy link
Contributor Author

alonho commented Dec 5, 2015

Before merging this I want to run the JS unit tests and also test some existing queries and dashboards.
It seems we maintained backward compatibility with all features.

A new little feature allows using grouping with pie charts, it generates a pie for every group (series):
screen shot 2015-12-05 at 2 34 41 am

@alonho alonho force-pushed the alonho:feature/plotly branch 3 times, most recently Dec 5, 2015
@alonho alonho force-pushed the alonho:feature/plotly branch to 0f82d4e Dec 6, 2015
A user can disable it if he has tons of series.
Now that we explicitly enable it, it's also visible for a single series.
@alonho
Copy link
Contributor Author

alonho commented Dec 7, 2015

Ready for merge! added a checkbox for disabling the legend.

@arikfr arikfr changed the title Replace highcharts with plotly Feature: replace HighCharts with Plotly Dec 7, 2015
arikfr added a commit that referenced this pull request Dec 9, 2015
Feature: replace HighCharts with Plotly
@arikfr arikfr merged commit 7e4f5e1 into getredash:master Dec 9, 2015
1 check passed
1 check passed
ci/circleci Your tests passed on CircleCI!
Details
@arikfr
Copy link
Member

arikfr commented Dec 9, 2015

🎉

@toyama0919
Copy link
Contributor

toyama0919 commented Dec 11, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.