Feature: replace HighCharts with Plotly #687

Merged
merged 4 commits into from Dec 9, 2015

Conversation

Projects
None yet
3 participants
@alonho
Contributor

alonho commented Dec 5, 2015

Solves #273

@alonho

This comment has been minimized.

Show comment
Hide comment
@alonho

alonho Dec 5, 2015

Contributor

Before merging this I want to run the JS unit tests and also test some existing queries and dashboards.
It seems we maintained backward compatibility with all features.

A new little feature allows using grouping with pie charts, it generates a pie for every group (series):
screen shot 2015-12-05 at 2 34 41 am

Contributor

alonho commented Dec 5, 2015

Before merging this I want to run the JS unit tests and also test some existing queries and dashboards.
It seems we maintained backward compatibility with all features.

A new little feature allows using grouping with pie charts, it generates a pie for every group (series):
screen shot 2015-12-05 at 2 34 41 am

alonho added some commits Dec 5, 2015

Add an option to disable chart legend.
A user can disable it if he has tons of series.
Now that we explicitly enable it, it's also visible for a single series.
@alonho

This comment has been minimized.

Show comment
Hide comment
@alonho

alonho Dec 7, 2015

Contributor

Ready for merge! added a checkbox for disabling the legend.

Contributor

alonho commented Dec 7, 2015

Ready for merge! added a checkbox for disabling the legend.

@arikfr arikfr changed the title from Replace highcharts with plotly to Feature: replace HighCharts with Plotly Dec 7, 2015

arikfr added a commit that referenced this pull request Dec 9, 2015

Merge pull request #687 from alonho/feature/plotly
Feature: replace HighCharts with Plotly

@arikfr arikfr merged commit 7e4f5e1 into getredash:master Dec 9, 2015

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@arikfr

This comment has been minimized.

Show comment
Hide comment
@arikfr

arikfr Dec 9, 2015

Member

🎉

Member

arikfr commented Dec 9, 2015

🎉

@toyama0919

This comment has been minimized.

Show comment
Hide comment
@toyama0919

toyama0919 Dec 11, 2015

Contributor

👍

Contributor

toyama0919 commented Dec 11, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment