Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: BigQuery: limit amount of MB processed per query #710

Merged
merged 4 commits into from Dec 16, 2015

Conversation

@ryotarai
Copy link
Contributor

@ryotarai ryotarai commented Dec 16, 2015

Sometimes, a query executed on BigQuery highly costs. To prevent that, I added totalMBytesProcessedLimit parameter to BigQuery runner.
If totalMBytesProcessedLimit is set, the runner will dry-run a query and check data size which will be processed, and if the data is larger than totalMBytesProcessedLimit, an error occur like the following image.

re dash new query 2015-12-16 20-31-56

This PR contains indent changes, so compare view ignoring whitespace is more understandable: https://github.com/getredash/redash/compare/master...ryotarai:bq-max-mb-processed?w=

@arikfr arikfr changed the title Add totalMBytesProcessedLimit param for BigQuery runner: Feature: BigQuery: limit amount of MB processed per query Dec 16, 2015
arikfr added a commit that referenced this pull request Dec 16, 2015
Feature: BigQuery: limit amount of MB processed per query
@arikfr arikfr merged commit 85916ef into getredash:master Dec 16, 2015
1 check passed
1 check passed
ci/circleci Your tests passed on CircleCI!
Details
@arikfr
Copy link
Member

@arikfr arikfr commented Dec 16, 2015

Awesome! Will be useful for the demo instance too (although until now it doesn't look like anyone been abusing it).

@ryotarai ryotarai deleted the ryotarai:bq-max-mb-processed branch Dec 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.