Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report url change to parent #252

Merged
merged 4 commits into from Jun 9, 2019

Conversation

Projects
None yet
2 participants
@ranbena
Copy link
Member

commented Jun 8, 2019

Discussion here https://discuss.redash.io/t/should-the-help-drawer-retain-state/3832/8.
Works with getredash/redash#3890.

Sends a postMessage with changed url to parent so it updates the "open in new window" button in the help drawer.

This PR diff looks big but it actually just turns a functional component into a class component and adds mount/unmount methods.

@ranbena ranbena requested review from gabrieldutra and kravets-levko Jun 8, 2019

@ranbena ranbena force-pushed the open-win2 branch from 6ffcb78 to b95eed6 Jun 8, 2019

@ranbena ranbena referenced this pull request Jun 8, 2019

Merged

Added “Open in new window” drawer menu button #3890

1 of 1 task complete
Show resolved Hide resolved src/components/Layout.jsx
"react-helmet": "5.2.0",
"react": "^16.8.6",
"react-dom": "^16.8.6",
"react-helmet": "^5.2.1",

This comment has been minimized.

Copy link
@ranbena

ranbena Jun 9, 2019

Author Member

Had to upgrade helmet as well cause of this.

@ranbena ranbena requested a review from kravets-levko Jun 9, 2019

Show resolved Hide resolved gatsby-browser.js
@kravets-levko
Copy link
Contributor

left a comment

Looks really nice 🙂

Show resolved Hide resolved gatsby-browser.js

@ranbena ranbena merged commit 84966e5 into master Jun 9, 2019

5 checks passed

Datree Smart Policy Best Practices Verification
Details
Datree insights datreeio insights events
Details
WIP Ready for review
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (arikfr) No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.