New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for OpenAPI v3.0 #31

Open
philsturgeon opened this Issue May 18, 2018 · 7 comments

Comments

Projects
None yet
2 participants
@philsturgeon

philsturgeon commented May 18, 2018

Hey folks, love the product!

Is supporting OpenAPI v3.0 on the roadmap? Your upload seems to not mind me importing from v3.0, as there is no validation on swagger: 2.0 in the file. It seems my openapi: 3.0.1 file snuck by the upload, created all the URLs and methods, but just had an empty response, as the responses look like this now:

      responses:
        '200':
          description: OK
          content:
            application/json:
              schema:
                type: object
                properties:
                  name:
                    type: string
                    example: foo

Do you think OpenAPI v3.0 support is something you'll be working on soon? It'd bring my company one step closer to being able to use this tool.

@nhoughto

This comment has been minimized.

Contributor

nhoughto commented May 21, 2018

@philsturgeon

This comment has been minimized.

philsturgeon commented May 21, 2018

@nhoughto

This comment has been minimized.

Contributor

nhoughto commented May 26, 2018

I'll get the team to investigate uplifting V2 to simple V3 support, from memory responses without schema based generation wasn't that hard.

@philsturgeon

This comment has been minimized.

philsturgeon commented May 30, 2018

Ahh sorry I meant responses with schemas. They're quite similar, and tools like https://github.com/Mermade/swagger2openapi can make it really easy to support both. Simply run everything through the converter, and tweak your existing code to support the v3 output.

@nhoughto

This comment has been minimized.

Contributor

nhoughto commented May 30, 2018

Ah yeah schemas are a bit more tricky, we are somewhat constrained by wanting to support both on-premise and cloud hosted options, but we will have another look, from memory converting it first hadn't come up as an option last time we went down this path. Thanks for the info

@philsturgeon

This comment has been minimized.

philsturgeon commented Jul 18, 2018

Hey @nhoughto, how's it coming along? I'm trying to implement a mock server at a hackathon currently, and I'm having to write my own. I'd love to be a paying customer so I can delete this junk after. :D

@nhoughto

This comment has been minimized.

Contributor

nhoughto commented Jul 18, 2018

Have been distracted sorry, there are other customers requesting openapi v3, so likely to get some focus soon. Its Top 5 at the moment =) Good luck with your hackathon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment