fix: switch to @vercel/ncc for proper dependency bundling #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace tsdown with @vercel/ncc which is the standard bundler for GitHub Actions - This ensures all dependencies (@actions/core, @actions/github, etc.) are properly bundled - Fixes 'Cannot find module @actions/core' error when action runs in GitHub workflows - All tests pass and bundle loads successfully
- Disable TypeScript declaration generation in tsconfig.json - Remove source maps to avoid absolute path issues in CI - Keep only necessary files (index.js and licenses.txt) in dist/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The previous bundler (tsdown) wasn't including node_modules dependencies in the output, causing the action to fail with module resolution errors when executed in GitHub Actions environments.
Solution
Switched to @vercel/ncc which is the standard and recommended bundler for GitHub Actions. It creates a self-contained JavaScript file with all dependencies included.
Test plan
pnpm run validate)