chore: Do not sync superuser/sudo cookies #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michellewzhang
approved these changes
Jan 17, 2024
|
Wait, why would we not also sync these cookies? |
ryan953
requested changes
Jan 19, 2024
|
I'm of the opinion this is a good move to make. We recently published a blog about defaulting to a strong privacy approach. The superuser cookies are powerful. Syncing them even if they are not needed, seems at odds with maintaining privacy. Of course, you can still manually copy the cookies over, but this PR is making it easy to do the right thing and prevents proliferation of elevated sessions. |
|
can we do a checkbox or something so it isn't doing it by default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not need to sync the superuser/sudo cookies.