-
-
Notifications
You must be signed in to change notification settings - Fork 19
feat(changelog): Group items by labels, like GitHub #628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the milestone-based changelog generation with a system that uses GitHub's `release.yml` categories. This change leverages [GitHub's native release notes configuration](https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes#configuration-options) for more flexible and powerful categorization of PRs based on labels and exclusion rules, moving away from the less flexible milestone-based approach.
src/utils/changelog.ts
Outdated
Comment on lines
608
to
610
| if (!commit.pr || !commit.author) { | ||
| leftovers.push(commit); | ||
| } else { |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
sentrivana
approved these changes
Nov 25, 2025
sentrivana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but my JS is ancient so maybe good if someone else takes a look.
sentrivana
added a commit
to getsentry/sentry-python
that referenced
this pull request
Nov 25, 2025
### Description Craft will support generating changelogs from PR labels in getsentry/craft#628. Add an initial config for our repo. #### Issues <!-- * resolves: #1234 * resolves: LIN-1234 --> #### Reminders - Please add tests to validate your changes, and lint your code using `tox -e linters`. - Add GH Issue ID _&_ Linear ID (if applicable) - PR title should use [conventional commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type) style (`feat:`, `fix:`, `ref:`, `meta:`) - For external contributors: [CONTRIBUTING.md](https://github.com/getsentry/sentry-python/blob/master/CONTRIBUTING.md), [Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord community](https://discord.gg/Ww9hbqr)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the milestone-based changelog generation with a system that uses GitHub's
release.ymlcategories.This change leverages GitHub's native release notes configuration for more flexible and powerful categorization of PRs based on labels and exclusion rules, moving away from the less flexible milestone-based approach.