Skip to content
This repository was archived by the owner on Aug 14, 2024. It is now read-only.

Conversation

@Spice-King
Copy link
Contributor

@Spice-King Spice-King commented Jul 1, 2021

Result of poking and prodding from getsentry/sentry#26851
Documentation for getsentry/self-hosted#1015

@vercel
Copy link

vercel bot commented Jul 1, 2021

@Spice-King is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@BYK BYK self-requested a review July 1, 2021 11:46
@BYK BYK self-assigned this Jul 1, 2021
Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome thank you so much!!!

@vercel
Copy link

vercel bot commented Jul 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/develop/BCXCmZMxzvQGEVUhYAdKxkS2j3G4
✅ Preview: https://develop-git-fork-spice-king-custom-ca-roots.sentry.dev

- Fiddle with nav
- Fiddle with formatting
@chadwhitacre
Copy link
Member

If I use custom CA roots, do those override or extend the system roots? Whichever it is, we should document that here.

@chadwhitacre
Copy link
Member

If I use custom CA roots, do those override or extend the system roots?

If I'm reading the docs for update-ca-certificates right, the answer is that it extends the system roots:

Furthermore all certificates with a .crt extension found below /usr/local/share/ca-certificates are also included as implicitly trusted.

Copy link
Member

@chadwhitacre chadwhitacre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, bounced CI ...

@BYK
Copy link
Member

BYK commented Jul 30, 2021

Failure is same on master so merging.

@BYK BYK merged commit 7ebb196 into getsentry:master Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants