feat: Add support for doing pipedream stages in parallel #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K8s deploys want to run in parallel instead of the current serial deploys that we do for code. This adds a parallel flag to pipedream that defaults to false to maintain current behaviour but enables parallel execution of all pipelines when wanted.
fpacifici
reviewed
Oct 18, 2024
There was a problem hiding this comment.
how did we end up writing tests in javascript ? Seems a new level of inconsistency
There was a problem hiding this comment.
🤷🏻 We'd need to ask Matt
|
Then looks good to me. Please fix the jsvscript format and I think it would be a good idea to get a review from @IanWoodard |
IanWoodard
approved these changes
Oct 30, 2024
This was referenced Oct 15, 2025
github-merge-queue bot
pushed a commit
to getsentry/relay
that referenced
this pull request
Oct 16, 2025
* Adds s4s2 as test region * fix(tests): Fixing pipedream tests by @IanWoodard in getsentry/gocd-jsonnet#81 * feat: Add support for doing pipedream stages in parallel by @rgibert in getsentry/gocd-jsonnet#80
phacops
pushed a commit
to getsentry/snuba
that referenced
this pull request
Oct 20, 2025
* Adds s4s2 as test region * fix(tests): Fixing pipedream tests by @IanWoodard in getsentry/gocd-jsonnet#81 * feat: Add support for doing pipedream stages in parallel by @rgibert in getsentry/gocd-jsonnet#80
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
K8s deploys want to run in parallel instead of the current serial deploys that we do for code. This adds a parallel flag to pipedream that defaults to false to maintain current behaviour but enables parallel execution of all pipelines when wanted.
This also standardizes the naming of the tests to be clear on serial vs parallel and adds vendor/ to gitignore so it doesn't get accidentally checked in.