Skip to content

update sentry_forked_djangorestframework_stubs==3.16.2.post1 #1608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sentry-release-bot merged 1 commit into from
Aug 14, 2025
+1 −0
Merged

update sentry_forked_djangorestframework_stubs==3.16.2.post1 #1608

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2010,6 +2010,7 @@ python_versions = <3.13
[sentry-forked-djangorestframework-stubs==3.15.3.post1]
[sentry-forked-djangorestframework-stubs==3.16.0.post1]
[sentry-forked-djangorestframework-stubs==3.16.1.post1]
[sentry-forked-djangorestframework-stubs==3.16.2.post1]

Comment on lines +2013 to 2014
Copy link

@seer-by-sentry seer-by-sentry bot Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential bug: Adding a package to packages.ini won't make it installable. The build process always runs incrementally and won't regenerate the index for this change, causing installation failures.

  • Description: The build process, specifically the make_index.py script, always runs in an incremental mode using the --previous-package-list-json flag. This incremental mode does not add new package entries from packages.ini to the index unless a new wheel is built. However, the build.py script will not build a new wheel for the added package sentry-forked-djangorestframework-stubs==3.16.2.post1 because it determines the package is already satisfied by existing wheels. Consequently, the new package entry will not be indexed, causing any downstream installation attempts for this specific version to fail with a package not found error.

  • Suggested fix: The build workflow needs a mechanism to trigger a full regeneration of the PyPI index when packages.ini is modified. This could involve conditionally removing the --previous-package-list-json flag from the make_index.py call to force a full rebuild when changes to packages.ini are detected.
    severity: 0.85, confidence: 0.95

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Contributor

@asottile-sentry asottile-sentry Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmao. absolute garbage

[sentry-forked-email-reply-parser==0.5.12.post1]

Expand Down
Loading