-
-
Notifications
You must be signed in to change notification settings - Fork 5
feat: add ops salt #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
build.py
Outdated
| if "/test/" in name \ | ||
| or "/tests/" in name \ | ||
| or "/examples/" in name: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally python should never have backslashes -- always use parens for this
but actually we should just upgrade pycparser instead rather than allowing all examples directories -- I upgraded pycparser in sentry to avoid the same thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah i was working on remerging and removing those backslashes (bad habit) as you were typing this out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately salt-ssh 3004.2 has - pycparser [required: ==2.19, installed: 2.19]...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
salt-ssh 3005 has - pycparser [required: ==2.21, installed: 2.21] but not sure if we want 3005 yet
|
lol i guess they have some package metadata wrong - missing platform markers |
|
closing in favor of #75 |
Second half of #72.