Skip to content

Conversation

@joshuarli
Copy link
Member

Second half of #72.

build.py Outdated
Comment on lines 525 to 527
if "/test/" in name \
or "/tests/" in name \
or "/examples/" in name:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally python should never have backslashes -- always use parens for this

but actually we should just upgrade pycparser instead rather than allowing all examples directories -- I upgraded pycparser in sentry to avoid the same thing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i was working on remerging and removing those backslashes (bad habit) as you were typing this out

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately salt-ssh 3004.2 has - pycparser [required: ==2.19, installed: 2.19]...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

salt-ssh 3005 has - pycparser [required: ==2.21, installed: 2.21] but not sure if we want 3005 yet

@joshuarli
Copy link
Member Author

lol error: PyObjC requires macOS to build

i guess they have some package metadata wrong - missing platform markers

@joshuarli
Copy link
Member Author

closing in favor of #75

@joshuarli joshuarli closed this Sep 14, 2022
@joshuarli joshuarli deleted the ops-salt branch September 14, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants