Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Middleware is broken and bursts in flames #1

Closed
wants to merge 3 commits into from

2 participants

@Almad

Connect middleware uses deprecated/purged API and thus creates sad heroku panda.

@mattrobenolt

Oops. I need to add some test coverage for the middleware!

Please revert the commit bumping the version and I'll merge this in and bump it on my own.

@mattrobenolt mattrobenolt closed this pull request from a commit
@mattrobenolt mattrobenolt Fixes #1 902116a
@mattrobenolt

Thank you. :)

@mattrobenolt

FYI, 0.2.1 has been pushed to npm

@Almad

Thanks for the fast release :)

@Almad

(...and sorry for bump, but I had to deploy to heroku)

@mattrobenolt

No problem. I haven't deployed anything on Heroku yet, so any hiccups you come across, feel free to let me know. :) I'll get something up there for testing sooner rather than later.

@Almad

So far, it looks like it's working, hiccups will be reported ,)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 22, 2012
  1. @Almad

    Fix middleware

    Almad authored
  2. @Almad

    Bump version for heroku cache

    Almad authored
  3. @Almad

    Fix versioning

    Almad authored
This page is out of date. Refresh to see the latest.
Showing with 4 additions and 4 deletions.
  1. +2 −2 lib/middleware/connect.js
  2. +2 −2 package.json
View
4 lib/middleware/connect.js
@@ -5,9 +5,9 @@ module.exports = function connectMiddleware(client) {
client = (client instanceof raven.Client) ? client : new raven.Client(client);
return function(err, req, res, next) {
var kwargs = parsers.parseRequest(req);
- client.createFromError(err, kwargs, function(result) {
+ client.captureError(err, kwargs, function(result) {
res.sentry = client.getIdent(result);
next(err, req, res);
});
};
-};
+};
View
4 package.json
@@ -2,7 +2,7 @@
"name": "raven",
"description": "A standalone (Node.js) client for Sentry",
"keywords": ["raven", "sentry", "python"],
- "version": "0.2.0",
+ "version": "0.2.1",
"repository": "git://github.com/mattrobenolt/raven-node.git",
"author": "Matt Robenolt <matt@ydekproductions.com>",
"main": "index",
@@ -23,4 +23,4 @@
"nock": "*",
"glob": "*"
}
-}
+}
Something went wrong with that request. Please try again.