This repository was archived by the owner on Oct 23, 2023. It is now read-only.
feat: Fall back to NODE_ENV for Sentry Environment #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
requested review from
a team
and removed request for
benvinegar
mitsuhiko
approved these changes
Sep 26, 2017
benvinegar
reviewed
Sep 27, 2017
docs/config.rst
Outdated
| .. describe:: SENTRY_ENVIRONMENT | ||
|
|
||
| Optionally set the environment name, e.g. "staging", "production". | ||
| Optionally set the environment name, e.g. "staging", "production". You can also use `NODE_ENV` variable instead. |
There was a problem hiding this comment.
Should probably change this to say, "Sentry will default to the value of NODE_ENV, if present."
kamilogorek
force-pushed
the
node-env
branch
from
f48693c to
a4853ce
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#383