New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve in_app detection #64

Closed

dcramer opened this issue Feb 5, 2013 · 2 comments

Labels

Member

dcramer commented Feb 5, 2013

Currently it marks all frames as in application in many conditions.

For example, one app their entire code has absolute paths that are all like /app/foo/XXX/...

The solution is likely to add in a source root configuration option, and when that is set prepend the app detect with that path.

(We should also remove the absolute detection in in_app, and only check for relative app/* etc paths)

Member Author

dcramer commented Feb 12, 2013

FWIW I added Configuration.project_root to aid this

zarqman mentioned this issue

Use Configuration.project_root when performing detection for in_app #96

Merged

Contributor

nateberkopec commented Mar 17, 2016

I'm pretty satisfied with this behavior r/n.

nateberkopec closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment