New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swallow specified exceptions #768

Closed
vassilevsky opened this Issue Oct 9, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@vassilevsky

vassilevsky commented Oct 9, 2017

Hi 馃檪

How bad of an idea is this on a scale of 1 to lack of generics in Go?

Raven.configure do |config|
  config.swallow_exceptions = [FooError, BarError]
end

Exceptions of these classes are then NOT raised after reporting.

I think it will be useful for non-critical, "good-to-know" exceptions.

@nateberkopec

This comment has been minimized.

Show comment
Hide comment
@nateberkopec

nateberkopec Oct 9, 2017

Member

Hm, can you give a concrete example of a type of exception you would do this with?

My first thought is that swallowing and not re-raising is a concern of the application, not raven-ruby.

Member

nateberkopec commented Oct 9, 2017

Hm, can you give a concrete example of a type of exception you would do this with?

My first thought is that swallowing and not re-raising is a concern of the application, not raven-ruby.

@vassilevsky

This comment has been minimized.

Show comment
Hide comment
@vassilevsky

vassilevsky Oct 11, 2017

I gave it another thought and concluded that this was a terrible idea indeed. Raven should be absolutely transparent to any application.

vassilevsky commented Oct 11, 2017

I gave it another thought and concluded that this was a terrible idea indeed. Raven should be absolutely transparent to any application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment