New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude all 4xx Rails errors #769

Merged
merged 1 commit into from Nov 20, 2017

Conversation

Projects
None yet
5 participants
@nateberkopec
Member

nateberkopec commented Oct 9, 2017

All Rails 4xx errors will be excluded with this change. I think this generally makes sense. Sentry's behavior, by default, should be to report programmer errors (bugs). A program rejecting invalid input (4xx) is not really an exception, and the program is behaving as intended.

  • Alphabetized the list
  • Added some comments
@cesc1989

This comment has been minimized.

Show comment
Hide comment
@cesc1989

cesc1989 Oct 10, 2017

We use Sentry in production and excluding 4xx would be kind of removing noise from the issues list. Those 4xx could be found by tests or QA prior to going to production. I think this would be good.

Came from twitter.

cesc1989 commented Oct 10, 2017

We use Sentry in production and excluding 4xx would be kind of removing noise from the issues list. Those 4xx could be found by tests or QA prior to going to production. I think this would be good.

Came from twitter.

@nateberkopec

This comment has been minimized.

Show comment
Hide comment
@nateberkopec

nateberkopec Oct 16, 2017

Member

Thanks for the feedback, all 👍

Member

nateberkopec commented Oct 16, 2017

Thanks for the feedback, all 👍

@nateberkopec nateberkopec added this to the 3.0.0 milestone Oct 23, 2017

@nateberkopec nateberkopec changed the base branch from master to v3 Nov 3, 2017

'ActionController::InvalidAuthenticityToken',
'ActionController::InvalidAuthenticityToken',

This comment has been minimized.

@tijmenb

tijmenb Nov 6, 2017

Contributor

This one is already being ignored.

@tijmenb

tijmenb Nov 6, 2017

Contributor

This one is already being ignored.

This comment has been minimized.

@nateberkopec

nateberkopec Nov 7, 2017

Member

TODO: fix that, also see if there's any common ancestors to these exception classes so I can just ignore those instead.

@nateberkopec

nateberkopec Nov 7, 2017

Member

TODO: fix that, also see if there's any common ancestors to these exception classes so I can just ignore those instead.

@nateberkopec nateberkopec merged commit 45ccc53 into v3 Nov 20, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gingerlime

This comment has been minimized.

Show comment
Hide comment
@gingerlime

gingerlime Jun 28, 2018

Any chance of backporting this to v2 ? (or when is v3 due?)

gingerlime commented Jun 28, 2018

Any chance of backporting this to v2 ? (or when is v3 due?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment