ref: Fix clippy 1.63.0 lints #1411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
approved these changes
Aug 11, 2022
jan-auer
requested changes
Aug 11, 2022
relay-common/src/constants.rs
Outdated
| // Note: This type is represented as a u8 in Snuba/Clickhouse, with Unknown being the default | ||
| // value. We use repr(u8) to statically validate that the trace status has 255 variants at most. | ||
| #[derive(Clone, Copy, Debug, PartialEq, Serialize)] | ||
| #[derive(Clone, Copy, Debug, PartialEq, Eq, Serialize)] |
Member
There was a problem hiding this comment.
Most of our schema types do not implement Eq for a reason, because that allows us to add floats without breaking equality. There's also absolutely no disadvantage to not implementing Eq in practice.
Ultimately, this comes down to API stability. I think we should disable this lint.
Member
There was a problem hiding this comment.
yeah i wasn't entirely sure about that lint but we don't really have a stable api at all so i don't care too much.
Member
Author
There was a problem hiding this comment.
There's also absolutely no disadvantage to not implementing Eq in practice.
I was surprised about this lint as well. Will remove it.
jan-auer
approved these changes
Aug 12, 2022
cleptric
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clippy::derive_partial_eq_without_eq(see discussion below).#skip-changelog