ref: Fix clippy 1.63.0 lints

relay-auth/src/lib.rs

@@ -2,6 +2,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 use std::fmt;
 use std::str::FromStr;
 

relay-aws-extension/src/lib.rs

@@ -26,6 +26,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 mod aws_extension;
 pub use aws_extension::*;

relay-cabi/src/lib.rs

@@ -95,6 +95,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 mod auth;
 mod constants;

relay-cabi/src/processing.rs

@@ -1,6 +1,7 @@
 // TODO: Fix casts between RelayGeoIpLookup and GeoIpLookup
 #![allow(clippy::cast_ptr_alignment)]
 #![deny(unused_must_use)]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 use std::cmp::Ordering;
 use std::ffi::CStr;

relay-common/src/lib.rs

@@ -4,6 +4,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 mod macros;
 

relay-config/src/lib.rs

@@ -4,6 +4,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 mod byte_size;
 mod config;

relay-ffi-macros/src/lib.rs

@@ -7,6 +7,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 use proc_macro::TokenStream;
 use quote::ToTokens;

relay-ffi/src/lib.rs

@@ -104,6 +104,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 use std::cell::RefCell;
 use std::error::Error;

relay-filter/src/lib.rs

@@ -11,6 +11,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 use std::net::IpAddr;
 

relay-general/derive/src/lib.rs

@@ -5,6 +5,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 mod empty;
 mod jsonschema;

relay-general/src/lib.rs

@@ -1,6 +1,7 @@
 // Clippy throws errors in situations where a closure is clearly the better way. An example is
 // `Annotated::as_str`, which can't be used directly because it's part of two impl blocks.
 #![allow(clippy::redundant_closure)]
+#![allow(clippy::derive_partial_eq_without_eq)]
 #![deny(unused_must_use)]
 #![doc(
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",

relay-general/src/store/normalize.rs

@@ -434,7 +434,7 @@ fn normalize_security_report(
         if !headers.contains("User-Agent") {
             headers.insert(
                 HeaderName::new("User-Agent"),
-                Annotated::new(HeaderValue::new(&(*client))),
+                Annotated::new(HeaderValue::new(client)),
             );
         }
     }

relay-log/src/lib.rs

@@ -108,6 +108,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 #[cfg(feature = "sentry")]
 mod sentry_failure;

relay-metrics/src/lib.rs

@@ -96,6 +96,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 mod aggregation;
 mod protocol;

relay-quotas/src/lib.rs

@@ -5,6 +5,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 /// The default timeout to apply when a scope is fully rejected. This
 /// typically happens for disabled keys, projects, or organizations.

relay-quotas/src/redis.rs

@@ -226,7 +226,7 @@ impl RedisRateLimiter {
         for (quota, is_rejected) in tracked_quotas.iter().zip(rejections) {
             if is_rejected {
                 let retry_after = self.retry_after((quota.expiry() - timestamp).as_secs());
-                rate_limits.add(RateLimit::from_quota(&*quota, &*item_scoping, retry_after));
+                rate_limits.add(RateLimit::from_quota(quota, &*item_scoping, retry_after));
             }
         }
 

relay-redis/src/lib.rs

@@ -7,6 +7,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 mod config;
 pub use self::config::*;

relay-sampling/src/lib.rs

@@ -3,6 +3,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 use std::borrow::Cow;
 use std::collections::{BTreeMap, HashMap};

relay-server/src/endpoints/project_configs.rs

@@ -45,7 +45,7 @@ impl<S> FromRequest<S> for VersionQuery {
     type Result = Self;
 
     fn from_request(req: &actix_web::HttpRequest<S>, _: &Self::Config) -> Self::Result {
-        Self::from_request(&*req)
+        Self::from_request(req)
     }
 }
 

relay-server/src/lib.rs

@@ -251,6 +251,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 mod actors;
 mod body;

relay-server/src/utils/multipart.rs

@@ -280,6 +280,7 @@ pub struct MultipartItems {
     remaining_size: usize,
     // Collect all form data in here.
     form_data: FormDataWriter,
+    #[allow(clippy::type_complexity)]
     infer_type: Box<dyn Fn(Option<&str>) -> AttachmentType>,
 }
 

relay-statsd/src/lib.rs

@@ -230,7 +230,7 @@ where
 {
     CURRENT_CLIENT.with(|client| {
         if let Some(client) = client {
-            f(&*client)
+            f(client)
         } else {
             R::default()
         }

relay-system/src/lib.rs

@@ -12,6 +12,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 pub mod compat;
 mod controller;

relay-test/src/lib.rs

@@ -25,6 +25,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 use std::{
     cell::RefCell,

relay/src/main.rs

@@ -89,6 +89,7 @@
     html_logo_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png",
     html_favicon_url = "https://raw.githubusercontent.com/getsentry/relay/master/artwork/relay-icon.png"
 )]
+#![allow(clippy::derive_partial_eq_without_eq)]
 
 mod cli;
 mod cliapp;