-
Notifications
You must be signed in to change notification settings - Fork 104
ref(replays): Add option gating Snuba publishing to ingest-replay-events #5088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
approved these changes
Aug 28, 2025
Member
Dav1dde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you can find an existing Replay integration test you can modify to show that this works.
Co-authored-by: David Herberth <david.herberth@sentry.io>
…github.com/getsentry/relay into cmanallen/replays-global-config-snuba-gate
cmanallen
added a commit
to getsentry/sentry
that referenced
this pull request
Aug 28, 2025
andrewshie-sentry
pushed a commit
to getsentry/sentry
that referenced
this pull request
Aug 28, 2025
constantinius
pushed a commit
to getsentry/sentry
that referenced
this pull request
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks the global config to see if it should or should not publish the replay-event to Snuba. For now the option should always be false until the recording consumer can be updated to handle publishing to Snuba.
Related: getsentry/sentry-kafka-schemas#434
Related: getsentry/sentry#98353