Skip to content

ref(breakdowns): All fields in breakdown config should be camelCase #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dashed merged 4 commits into from
May 14, 2021
Merged

ref(breakdowns): All fields in breakdown config should be camelCase #993

dashed merged 4 commits into from
May 14, 2021

Conversation

@dashed
Copy link
Member

@dashed dashed commented May 11, 2021

@dashed dashed requested review from a team and untitaker May 11, 2021 20:00
@dashed dashed self-assigned this May 11, 2021
@dashed dashed mentioned this pull request May 11, 2021
Merged
@untitaker
Copy link
Member

untitaker commented May 12, 2021

This is also a good change, but my suggestion was about the span_operations in type: "span_operations" in relay projectconfig. This change affects the matches key which does not make a difference.

@dashed dashed changed the title ref(breakdowns): Rename all fields in SpanOperationsConfig struct to camelCase ref(breakdowns): All fields in breakdown config should be camelCase May 13, 2021
@dashed dashed requested a review from untitaker May 13, 2021 23:28
@dashed dashed merged commit 802953b into master May 14, 2021
@dashed dashed deleted the camelCase-breakdowns branch May 14, 2021 18:50
@holophil holophil mentioned this pull request May 17, 2021
Closed
untitaker added a commit that referenced this pull request May 17, 2021
@untitaker
Revert "ref(breakdowns): All fields in breakdown config should be cam…
e9e37cc 
…elCase (#993)"

This reverts commit 802953b.
@untitaker untitaker mentioned this pull request May 17, 2021
Merged
jan-auer pushed a commit that referenced this pull request May 17, 2021
@untitaker
Revert "ref(breakdowns): All fields in breakdown config should be cam…
83a7410 
…elCase (#993)" (#1002)

This reverts commit 802953b.
@dashed dashed mentioned this pull request Jun 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@untitaker untitaker untitaker approved these changes

Assignees

@dashed dashed

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dashed @untitaker