Skip to content

Conversation

@fnkr
Copy link
Contributor

@fnkr fnkr commented Jul 7, 2021

http_proxy, https_proxy and no_proxy environment variables should be forwarded to the curl container.

@BYK BYK requested a review from fpacifici July 7, 2021 12:50
@BYK
Copy link
Member

BYK commented Jul 7, 2021

Thanks so much for the PR!

@fnkr fnkr changed the title Respect http_proxy/HTTPS_PROXY when installing Sentry/wal2json Respect http_proxy/https_proxy/no_proxy when installing Sentry/wal2json Jul 7, 2021
@fnkr fnkr requested a review from BYK July 7, 2021 13:52
@BYK BYK changed the title Respect http_proxy/https_proxy/no_proxy when installing Sentry/wal2json fix(wal2json): Respect http_proxy/https_proxy/no_proxy when installing Jul 7, 2021
@BYK BYK enabled auto-merge (squash) July 7, 2021 14:04
@BYK BYK merged commit bd8fbf9 into getsentry:master Jul 7, 2021
@fnkr fnkr deleted the respect-http-proxy branch July 7, 2021 14:23
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants