Update check-minimum-requirements.sh #1061
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updatet minimum docker-compose version to 1.29.2
Member
chadwhitacre
requested changes
Aug 16, 2021
Member
chadwhitacre
left a comment
chadwhitacre
left a comment
There was a problem hiding this comment.
Not sure we want to increase MIN_COMPOSE_VERSION in light of #1062.
Member
|
@chadwhitacre I think there's a point here: we must have a test case with the minimum supported version of |
Member
Member
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updatet minimum docker-compose version to 1.29.2.
I saw the new version 21.8 and just tried to update on my server. Unfortunately the install.sh script broke without a proper error message. Then I saw that the docker-compose version must be higher on the release, updated it on my server and the installer then ran through.
So that a proper error message should come here is my patch for the 21.8.0 .