ci(github): Reimplement CI in GitHub Actions #634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Part of #627, sets us up for expanding the OS matrix we test against.
chadwhitacre
changed the title
|
Ready for review, @BYK et al. |
BYK
approved these changes
Aug 20, 2020
|
GHA has been quite stable for some other things so I think it should be safe to remove Travis and see if we can make this even better. Maybe separate install and actual test steps? I don't know if we can leverage any caching easily as you indicated but why not try? |
BYK
reviewed
Aug 20, 2020
| @@ -0,0 +1,33 @@ | |||
| name: test | |||
| on: push | |||
There was a problem hiding this comment.
Oh wait, this will only run on branch pushes. We should also add pull_request for this to be a proper commit check, right @chadwhitacre?
There was a problem hiding this comment.
Yup, good call. Maybe #639 does what we want?
This was referenced Aug 21, 2020
Merged
BYK
added a commit
that referenced
this pull request
Aug 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly wooden port of the Travis CI config to GitHub actions. Note that this doesn't remove Travis yet. I figure we should run both in parallel for a bit to make sure GitHub Actions is trustworthy. E.g., there might be some caching we want to do to speed up the build, I didn't look into that yet.
Presumably there's some button clicking that needs to happen before this'll run in the main repo. Here's a good run in my fork:
https://github.com/chadwhitacre/onpremise/runs/998127947
And here's a sample bad run in my fork, showing that test failures indeed break the build:
https://github.com/chadwhitacre/onpremise/runs/998137076
Part of #627.