This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
modified sample to reproduce #379 #443
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
mitsuhiko
reviewed
Jun 2, 2020
| jstring result = (jstring) env->CallStaticObjectMethod(clazz, method); | ||
| // if I do a NPE check, it bails out and it works | ||
| // if (result == NULL) { | ||
| // return; |
There was a problem hiding this comment.
Let's try to see what happens with the uncaught exception handler here if we do env->ExceptionClear(env) before the return.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a draft to reproduce #379
paste bin
https://pastebin.com/fy5LmJgv
findings:
when there are an uncaught exception and a segfault at the same time as this example does, the
UncaughtExceptionHandlerIntegration.uncaughtException and the segfault handler try to execute its handlers, but one interferes in the other.
eg UncaughtExceptionHandlerIntegration.uncaughtException probably sends a SIGABRT to the native layer and vice-versa, so sometimes none of them are able to finish its job.
If you add a breakpoint in one of them, the other handler is able to do its job and generate a crash event.