From 786e89438ad7577abbde500c42a033b7d14812b9 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon, 22 Sep 2025 00:25:14 +0000 Subject: [PATCH 1/2] build(rust): Update Rust toolchain to 1.90 --- rust-toolchain.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rust-toolchain.toml b/rust-toolchain.toml index 6697c67365..d578735b96 100644 --- a/rust-toolchain.toml +++ b/rust-toolchain.toml @@ -1,4 +1,4 @@ [toolchain] # We pin the minor version to prevent new Clippy lints from breaking CI. # But, we still want to pick up new patch versions. -channel = "1.89" +channel = "1.90" From cdb08a587ade730d2b4d91ad21b8781b5bf6204c Mon Sep 17 00:00:00 2001 From: Daniel Szoke Date: Mon, 22 Sep 2025 10:01:28 +0200 Subject: [PATCH 2/2] fix the clippy lints These are the fixed lints, for reference warning: unnecessary parentheses around closure body --> src/commands/monitors/list.rs:20:30 | 20 | monitors.sort_by_key(|p| (p.name.clone())); | ^ ^ | = note: `#[warn(unused_parens)]` on by default help: remove these parentheses | 20 - monitors.sort_by_key(|p| (p.name.clone())); 20 + monitors.sort_by_key(|p| p.name.clone()); | warning: struct `GitHubAsset` is never constructed --> src/api/mod.rs:2181:8 | 2181 | struct GitHubAsset { | ^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default warning: struct `GitHubRelease` is never constructed --> src/api/mod.rs:2187:8 | 2187 | struct GitHubRelease { | ^^^^^^^^^^^^^ --- src/api/mod.rs | 12 ------------ src/commands/monitors/list.rs | 2 +- 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/src/api/mod.rs b/src/api/mod.rs index dd3b03c9b7..b836c98a80 100644 --- a/src/api/mod.rs +++ b/src/api/mod.rs @@ -2177,18 +2177,6 @@ pub struct ReleaseCommit { pub id: String, } -#[derive(Debug, Serialize, Deserialize)] -struct GitHubAsset { - browser_download_url: String, - name: String, -} - -#[derive(Debug, Serialize, Deserialize)] -struct GitHubRelease { - tag_name: String, - assets: Vec, -} - #[derive(Debug, Serialize, Deserialize)] struct RegistryRelease { version: String, diff --git a/src/commands/monitors/list.rs b/src/commands/monitors/list.rs index d948033519..b68d28e1d6 100644 --- a/src/commands/monitors/list.rs +++ b/src/commands/monitors/list.rs @@ -17,7 +17,7 @@ pub fn execute(matches: &ArgMatches) -> Result<()> { let api = Api::current(); let org = config.get_org(matches)?; let mut monitors = api.authenticated()?.list_organization_monitors(&org)?; - monitors.sort_by_key(|p| (p.name.clone())); + monitors.sort_by_key(|p| p.name.clone()); let mut table = Table::new(); table