ci: Simulator UI Tests #1558
Merged
ci: Simulator UI Tests #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipphofmann
commented
Dec 17, 2021
| @@ -35,13 +35,13 @@ class SpanObserver: NSObject { | |||
| func addSpanObserver(forKeyPath keyPath: String, callback : @escaping (Span) -> Void) { | |||
| callbacks[keyPath] = callback | |||
| //The given span may be a SentryTracer that wont respond to KVO. We need to get the root Span | |||
| let span = span.rootSpan() ?? span | |||
| (span as? NSObject)?.addObserver(self, forKeyPath: keyPath, options: .new, context: nil) | |||
| let spanToObserve = span.rootSpan() ?? span | |||
There was a problem hiding this comment.
Didn't compile with Xcode 12.
There was a problem hiding this comment.
Do you have the error message?
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## master #1558 +/- ##
==========================================
- Coverage 95.96% 95.94% -0.02%
==========================================
Files 157 157
Lines 7061 7061
==========================================
- Hits 6776 6775 -1
- Misses 285 286 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace flaky SauceLabs tests with running UI tests on simulators. In another PR, I'm going to enable SauceLabs again.
#skip-changelog