ref: Deprecate not needed option sdkInfo

[kevinrenskers]

📜 Description

options.sdkInfo is deprecated; SentryMeta is now the only source of truth. The values can be overridden by hybrid SDKs via PrivateSentrySDKOnly.

💡 Motivation and Context

Closes #1884

💚 How did you test it?

All the existing tests still run after this refactor. Added new tests.

📝 Checklist

• I reviewed the submitted code
• I added tests to verify the changes
• I updated the docs if needed
• Review from the native team if needed
• No breaking changes

#skip-changelog

🔮 Next steps

[kevinrenskers]

It really feels to me that we should deprecate the entire SentrySdkInfo class; just move its serialize method to SentryMeta. It should be removed from SentryOptions and from SentryEnvelopeHeader, and then this class is basically not used anymore. SentrySdkInfo doesn't really have a purpose anymore.

[kevinrenskers]

Why is testVersion failing on CI, but working on my machine? I don't really understand this test - based on CFBundleIdentifier we test if CFBundleShortVersionString is equal to SentryMeta.versionString. Why is that failing all of a sudden? Where do we overwrite that value, and why? The comment in that test says "since this will be the app version instead of our SDK version" which is weird to me, so sometimes the SDK version is the app version?

[philipphofmann]

Almost LGTM. I'm looking into why testVersion is failing at the moment.

[philipphofmann]

@kevinrenskers, testVersion fails because some tests set the SentryMeta.version to 1.2.3-alpha.0 and don't reset it afterward in the test. Search for 1.2.3-alpha.0 in the project and you are going to find them.

[philipphofmann]

I'm not sure if the tests will succeed. We could add resetSDKInfo, that is going to restore the default values, make it only visible for testing, and call it in tearDown in the ObjC tests and in clearTestState. For only making it visible for testing, we can create a test category like, for example, SentryClient+TestInit.h

[kevinrenskers]

Looks like all tests are passing now 🎉

[philipphofmann]

LGTM