-
-
Notifications
You must be signed in to change notification settings - Fork 371
Test UI test on Cirrus Labs #6576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6576 +/- ##
=============================================
- Coverage 85.513% 85.477% -0.037%
=============================================
Files 451 451
Lines 27584 27584
Branches 12072 12076 +4
=============================================
- Hits 23588 23578 -10
- Misses 3951 3961 +10
Partials 45 45 see 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…rrus_labs_ui_test_attempt_3
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0309548 | 1225.04 ms | 1252.82 ms | 27.77 ms |
| 326984b | 1235.06 ms | 1252.75 ms | 17.69 ms |
| 570f725 | 1206.00 ms | 1238.96 ms | 32.96 ms |
| be882e4 | 1199.35 ms | 1231.20 ms | 31.86 ms |
| e70670c | 1223.47 ms | 1238.67 ms | 15.20 ms |
| 664c060 | 1215.48 ms | 1244.41 ms | 28.93 ms |
| fbcffd6 | 1208.27 ms | 1236.60 ms | 28.34 ms |
| 8f2120f | 1235.92 ms | 1249.67 ms | 13.75 ms |
| 26f7b17 | 1218.47 ms | 1253.82 ms | 35.35 ms |
| e64d3d4 | 1241.90 ms | 1260.10 ms | 18.20 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0309548 | 23.75 KiB | 994.74 KiB | 970.99 KiB |
| 326984b | 23.74 KiB | 926.64 KiB | 902.90 KiB |
| 570f725 | 23.74 KiB | 913.38 KiB | 889.63 KiB |
| be882e4 | 23.75 KiB | 946.69 KiB | 922.94 KiB |
| e70670c | 23.75 KiB | 975.19 KiB | 951.45 KiB |
| 664c060 | 23.74 KiB | 977.41 KiB | 953.67 KiB |
| fbcffd6 | 23.75 KiB | 987.95 KiB | 964.20 KiB |
| 8f2120f | 23.75 KiB | 941.78 KiB | 918.03 KiB |
| 26f7b17 | 23.75 KiB | 960.93 KiB | 937.19 KiB |
| e64d3d4 | 23.75 KiB | 855.37 KiB | 831.62 KiB |
Previous results on branch: itay/cirrus_labs_ui_test_attempt_3
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ec9bc10 | 1223.81 ms | 1247.45 ms | 23.63 ms |
| f4a03bb | 1229.43 ms | 1263.87 ms | 34.44 ms |
| 476c28b | 1240.60 ms | 1271.71 ms | 31.10 ms |
| 02d7a75 | 1211.91 ms | 1251.87 ms | 39.95 ms |
| 69d79c9 | 1229.76 ms | 1263.74 ms | 33.99 ms |
| 011565c | 1219.98 ms | 1265.00 ms | 45.02 ms |
| 63b32f0 | 1204.75 ms | 1229.52 ms | 24.77 ms |
| 4b64d82 | 1227.84 ms | 1239.69 ms | 11.85 ms |
| 637107e | 1219.92 ms | 1254.96 ms | 35.04 ms |
| e0dec78 | 1218.43 ms | 1249.20 ms | 30.77 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ec9bc10 | 23.75 KiB | 1.01 MiB | 1016.24 KiB |
| f4a03bb | 23.75 KiB | 1.02 MiB | 1016.53 KiB |
| 476c28b | 23.75 KiB | 1.01 MiB | 1016.13 KiB |
| 02d7a75 | 23.75 KiB | 1.01 MiB | 1016.24 KiB |
| 69d79c9 | 23.75 KiB | 1.01 MiB | 1016.13 KiB |
| 011565c | 23.75 KiB | 1.01 MiB | 1016.12 KiB |
| 63b32f0 | 23.75 KiB | 1.01 MiB | 1016.23 KiB |
| 4b64d82 | 23.75 KiB | 1.02 MiB | 1016.75 KiB |
| 637107e | 23.75 KiB | 1.01 MiB | 1016.14 KiB |
| e0dec78 | 23.75 KiB | 1.02 MiB | 1016.53 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's give this a shot. Thanks @itaybre
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
Test PR for cirrus labs
Still pending:
Closes #6601