Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add url as configurable parameter #17

Merged
merged 3 commits into from Nov 4, 2021
Merged

Conversation

Amir-P
Copy link
Contributor

@Amir-P Amir-P commented Nov 2, 2021

馃摐 Description

Added url as configurable parameter

馃挕 Motivation and Context

To use this plugin with on-premise Sentry servers

馃挌 How did you test it?

With our own on-premise Sentry server!

馃摑 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

@marandaneto
Copy link
Contributor

@Amir-P thanks for doing that.

@marandaneto
Copy link
Contributor

@Amir-P please fix the formatting and add a changelog, so we can merge and release, thanks

@Amir-P
Copy link
Contributor Author

Amir-P commented Nov 3, 2021

@marandaneto Done.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
@marandaneto
Copy link
Contributor

@brustolin or @philipphofmann would you like to have a look?

@marandaneto marandaneto changed the title Fixed #16 Add url as configurable parameter Nov 4, 2021
Copy link
Collaborator

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto merged commit 4786f9c into getsentry:main Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants