From 453e1bca2bc18a0a639cc7f796ed58c7c44d89b7 Mon Sep 17 00:00:00 2001 From: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com> Date: Wed, 16 Nov 2022 21:24:20 +0100 Subject: [PATCH] VendorId should be a String (#1112) --- CHANGELOG.md | 4 ++++ dart/lib/src/protocol/sentry_gpu.dart | 4 ++-- dart/test/protocol/sentry_gpu_test.dart | 8 ++++---- flutter/android/build.gradle | 2 +- 4 files changed, 11 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 75ef98f4d..c7051a67b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,7 @@ ### Fixes +- VendorId should be a String ([#1112](https://github.com/getsentry/sentry-dart/pull/1112)) - Disable `enableUserInteractionBreadcrumbs` on Android when `enableAutoNativeBreadcrumbs` is disabled ([#1131](https://github.com/getsentry/sentry-dart/pull/1131)) - Transaction name is reset after the transaction finishes ([#1125](https://github.com/getsentry/sentry-dart/pull/1125)) @@ -12,6 +13,9 @@ - Bump Cocoa SDK from v7.30.2 to v7.31.0 ([#1132](https://github.com/getsentry/sentry-dart/pull/1132)) - [changelog](https://github.com/getsentry/sentry-cocoa/blob/master/CHANGELOG.md#7310) - [diff](https://github.com/getsentry/sentry-cocoa/compare/7.30.2...7.31.0) +- Bump Android SDK from v6.7.0 to v6.7.1 ([#1112](https://github.com/getsentry/sentry-dart/pull/1112)) + - [changelog](https://github.com/getsentry/sentry-java/blob/main/CHANGELOG.md#671) + - [diff](https://github.com/getsentry/sentry-java/compare/6.7.0...6.7.1) ## 6.15.1 diff --git a/dart/lib/src/protocol/sentry_gpu.dart b/dart/lib/src/protocol/sentry_gpu.dart index 64747eb86..f428e674b 100644 --- a/dart/lib/src/protocol/sentry_gpu.dart +++ b/dart/lib/src/protocol/sentry_gpu.dart @@ -24,7 +24,7 @@ class SentryGpu { final int? id; /// The PCI vendor identifier of the graphics device. - final int? vendorId; + final String? vendorId; /// The vendor name as reported by the graphics device. final String? vendorName; @@ -150,7 +150,7 @@ class SentryGpu { SentryGpu copyWith({ String? name, int? id, - int? vendorId, + String? vendorId, String? vendorName, int? memorySize, String? apiType, diff --git a/dart/test/protocol/sentry_gpu_test.dart b/dart/test/protocol/sentry_gpu_test.dart index c1e1c363b..443b50ea9 100644 --- a/dart/test/protocol/sentry_gpu_test.dart +++ b/dart/test/protocol/sentry_gpu_test.dart @@ -6,7 +6,7 @@ void main() { final sentryGpu = SentryGpu( name: 'fixture-name', id: 1, - vendorId: 2, + vendorId: '2', vendorName: 'fixture-vendorName', memorySize: 3, apiType: 'fixture-apiType', @@ -17,7 +17,7 @@ void main() { final sentryGpuJson = { 'name': 'fixture-name', 'id': 1, - 'vendor_id': 2, + 'vendor_id': '2', 'vendor_name': 'fixture-vendorName', 'memory_size': 3, 'api_type': 'fixture-apiType', @@ -63,7 +63,7 @@ void main() { final copy = data.copyWith( name: 'name1', id: 11, - vendorId: 22, + vendorId: '22', vendorName: 'vendorName1', memorySize: 33, apiType: 'apiType1', @@ -74,7 +74,7 @@ void main() { expect('name1', copy.name); expect(11, copy.id); - expect(22, copy.vendorId); + expect('22', copy.vendorId); expect('vendorName1', copy.vendorName); expect(33, copy.memorySize); expect('apiType1', copy.apiType); diff --git a/flutter/android/build.gradle b/flutter/android/build.gradle index 98a7d6cd7..7a08ce593 100644 --- a/flutter/android/build.gradle +++ b/flutter/android/build.gradle @@ -54,6 +54,6 @@ android { } dependencies { - api 'io.sentry:sentry-android:6.7.0' + api 'io.sentry:sentry-android:6.7.1' implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version" }